Skip to content

Revert swift-corelibs-foundation-windows checkout #75255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jmschonfeld
Copy link
Contributor

We've been able to sort out the Windows issues and we can now land the Foundation re-core in parallel on Windows and Linux removing the need for a separate checkout

@jmschonfeld jmschonfeld requested a review from compnerd July 15, 2024 20:15
@jmschonfeld jmschonfeld requested a review from shahmishal as a code owner July 15, 2024 20:15
@jmschonfeld
Copy link
Contributor Author

@swift-ci please smoke test

Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💙

Copy link
Contributor

@grynspan grynspan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jmschonfeld jmschonfeld merged commit b55f881 into swiftlang:main Jul 16, 2024
3 checks passed
@jmschonfeld jmschonfeld deleted the isolate-windows-foundation-build-revert branch July 16, 2024 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants