[Concurrency] Fix disallowed override isolation to carry `@preconcurr… #75087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hborla
approved these changes
Jul 9, 2024
|
@swift-ci please test |
xedin
force-pushed
the
rdar-130776220-limited
branch
from
6e9a77b to
e165862
Compare
|
@swift-ci please test |
|
@slavapestov This PR reverts 0097ef6 because diagnostics reply on flags set on "unspecified" isolation at the moment, to downgrade diagnostics in Swift 5 mode. |
…ency` bit If ObjC member cannot be overridden due to isolation mismatch set `@preconcurrency` bit to make the diagnostic a warning instead of an error in Swift 5 mode. Resolves: rdar://130776220
There are a few spots in `ActorIsolationRequest` that produce `unspecified` isolation with `preconcurrency` bit set and diagnostics rely on that to make downgrade decisions in Swift 5 mode. This reverts commit 0097ef6.
xedin
force-pushed
the
rdar-130776220-limited
branch
from
e165862 to
65fb35c
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ency` bit
If ObjC member cannot be overridden due to isolation mismatch set
@preconcurrencybit to make the diagnostic a warning instead of an error in Swift 5 mode.Resolves: rdar://130776220