[cxx-interop] Builtin functions should ignore return type nullability… #74494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyp
requested review from
zoecarver,
egorzhdan,
beccadax and
ian-twilightcoder
as code owners
|
@swift-ci please smoke test |
compnerd
reviewed
Jun 17, 2024
hjyamauchi
approved these changes
Jun 18, 2024
hyp
force-pushed
the
eng/android-memcpy-nonnull-me-timbers
branch
from
ce9493d to
5976241
Compare
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
hyp
force-pushed
the
eng/android-memcpy-nonnull-me-timbers
branch
from
5976241 to
8426df1
Compare
|
@swift-ci please test source compatibility |
|
@swift-ci please test |
hyp
force-pushed
the
eng/android-memcpy-nonnull-me-timbers
branch
from
8426df1 to
5a28cdb
Compare
|
@swift-ci please test source compatibility |
|
@swift-ci please test |
hyp
force-pushed
the
eng/android-memcpy-nonnull-me-timbers
branch
from
5a28cdb to
b92fcc2
Compare
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
@swift-ci please test windows platform |
…re return type nullability to be compatible with C interop In C interop mode, the return type of builtin functions like 'memcpy' from headers like 'string.h' drops any nullability specifiers from their return type, and preserves it on the declared return type. Thus, in C mode the imported return type of such functions is always optional. However, in C++ interop mode, the return type of builtin functions can preseve the nullability specifiers on their return type, and thus the imported return type of such functions can be non-optional, if the type is annotated with `_Nonnull`. The difference between these two modes can break cross-module Swift serialization, as Swift will no longer be able to resolve an x-ref such as 'memcpy' from a Swift module that uses C interop, within a Swift context that uses C++ interop. In order to avoid the x-ref resolution failure, normalize the return type's nullability for builtin functions in C++ interop mode, to match the imported type in C interop mode. This fixed an issue when using 'memcpy' from the Android NDK in a x-module context, like between Foundation (that inlines it) and another user module.
hyp
force-pushed
the
eng/android-memcpy-nonnull-me-timbers
branch
from
b92fcc2 to
e4ad3c1
Compare
|
@swift-ci please test |
|
@swift-ci please test |
|
@swift-ci please test windows platform |
|
@swift-ci please test windows platform |
1 similar comment
|
@swift-ci please test windows platform |
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… to be compatible with C interop
In C interop mode, the return type of builtin functions like 'memcpy' drops any nullability specifiers from their return type, and preserves it on the declared return type. Thus, in C mode the imported return type of such functions is always optional. However, in C++ interop mode, the return type of builtin functions can preseve the nullability specifiers on their return type, and thus the imported return type of such functions can be non-optional, if the type is annotated with
_Nonnull. The difference between these two modes can break cross-module Swift serialization, as Swift will no longer be able to resolve an x-ref such as 'memcpy' from a Swift module that uses C interop, within a Swift context that uses C++ interop. In order to avoid the x-ref resolution failure, normalize the return type's nullability for builtin functions in C++ interop mode, to match the imported type in C interop mode.This fixed an issue when using 'memcpy' from the Android NDK in a x-module context, like between Foundation (that inlines it) and another user module.