[6.0][ModuleInterface] Save -public-autolink-library module option
#74323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Serialize the `-public-autolink-library <name>` option to the moduleinterface file because it can affect the LINK_LIBRARY entries in a swiftmodule file. Without saving the option, the library won't be linked when a module compiled from the moduleinterface is used. This change marks the `-public-autolink-library` option as a module interface option and reads it when building a swiftmodule by module loader.
kateinoigakukun
changed the title
-public-autolink-library module option-public-autolink-library module option
kateinoigakukun
added
🍒 release cherry pick
|
@swift-ci test |
MaxDesiatov
added
the
bug
nkcsgexi
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Fixes inconsistent swiftmodule compilation issue revealed by recent explicit module improvements
Scope: Only affects static-linking scenario
Risk: Low; just save/restore an option that has existed since Swift 5.6 and only affects to static-linking
Testing: Added a new test to cover the case
Reviewer: @artemcm
Original PR: #74277