🍒[cxx-interop] Only run tests for reference types against a recent Swift runtime #74293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ft runtime Having a Swift array of C++ reference types without crashing at runtime only became possible recently (#73615). When building against an older runtime, one would still see runtime crashes. This is expected because part of the fix is in the Swift runtime. This makes sure we don't try to run tests for C++ reference types with an older Swift runtime. rdar://128681137 (cherry picked from commit 0f420fe)
Contributor
Author
|
@swift-ci please test |
shahmishal
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Having a Swift array of C++ reference types without crashing at runtime only became possible recently (#73615). When building against an older runtime, one would still see runtime crashes. This is expected because part of the fix is in the Swift runtime.
This makes sure we don't try to run tests for C++ reference types with an older Swift runtime.
Scope: Only changes tests.
Risk: Low.
Issue: rdar://128681137
Original PR: #74261