Skip to content

[6.0] Make BorrowingSwitch a LANGUAGE_FEATURE. #74226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jckarter
Copy link
Contributor

@jckarter jckarter commented Jun 7, 2024

Explanation: Changes the compiler's classification of $BorrowingSwitch to be a regular language feature rather than an "upcoming feature", since the feature flag doesn't change any source-breaking behavior.
Scope: Should be no change for most Swift developers.
Issue: rdar://129417451
Original PR: #74223
Risk: Low. Only affects the behavior of a feature flag used for bringup of a feature.
Testing: N/A
Reviewer: @atrick

It doesn't guard any source breaks, so it doesn't need to be an UPCOMING_FEATURE.
rdar://129417451
@jckarter jckarter requested a review from a team as a code owner June 7, 2024 22:05
@jckarter
Copy link
Contributor Author

jckarter commented Jun 7, 2024

@swift-ci Please test

@jckarter jckarter changed the title Make BorrowingSwitch a LANGUAGE_FEATURE. [6.0] Make BorrowingSwitch a LANGUAGE_FEATURE. Jun 10, 2024
Copy link
Contributor

@atrick atrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jckarter jckarter merged commit 842e083 into swiftlang:release/6.0 Jun 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants