[Completion] Only skip result builder expressions in the same builder #74219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we would skip any expression in a result builder that didn't contain the completion token, but that would cause issues if e.g the result builder was needed to infer the type of a variable that we're completing on. Instead, only skip expressions in a result builder if the completion token is in the same builder and the expression itself doesn't contain the completion. rdar://127154780
hamishknight
requested review from
ahoppen,
bnbarham,
rintaro,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please test |
|
@swift-ci please SourceKit stress test |
xedin
approved these changes
Jun 7, 2024
|
Same stress tester UPASS as on main |
jefferyq2
pushed a commit
to jefferyq2/swift
that referenced
this pull request
Jun 10, 2024
[Completion] Only skip result builder expressions in the same builder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we would skip any expression in a result builder that didn't contain the completion token, but that would cause issues if e.g the result builder was needed to infer the type of a variable that we're completing on. Instead, only skip expressions in a result builder if the completion token is in the same builder and the expression itself doesn't contain the completion.
rdar://127154780
Resolves #72399