[SourceKit] Don’t set DisableModulesValidateSystemDependencies to true
#74213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…true` It appears that swiftlang/llvm-project@a6ebd30 changed the behavior of `-fno-modules-validate-system-headers` (aka. `DisableModulesValidateSystemDependencies`) in conjunction with `-fmodules-validate-once-per-build-session`: Before that change, `-fno-modules-validate-system-headers` needed to be passed for `-fmodules-validate-once-per-build-session` to have any effect (we were always validating system dependencies if `-fno-modules-validate-once-per-build-session` was not set). After the change, `-fno-modules-validate-once-per-build-session` causes system dependencies to never be validated, independent of the build session timestamp. This change should have no effect on Xcode because it adds `-fmodules-validate-system-headers` to the compiler arguments for Swift files, which overrides `SearchPathOpts.DisableModulesValidateSystemDependencies = true;`
|
@swift-ci Please test |
bnbarham
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-fno-modules-validate-system-headers(aka.DisableModulesValidateSystemDependencies) in conjunction with-fmodules-validate-once-per-build-session: Before that change,-fno-modules-validate-system-headersneeded to be passed for-fmodules-validate-once-per-build-sessionto have any effect (we were always validating system dependencies if-fno-modules-validate-once-per-build-sessionwas not set). After the change,-fno-modules-validate-once-per-build-sessioncauses system dependencies to never be validated, independent of the build session timestamp.This change should have no effect on Xcode because it adds
-fmodules-validate-system-headersto the compiler arguments for Swift files, which overridesSearchPathOpts.DisableModulesValidateSystemDependencies = true;DisableModulesValidateSystemDependenciestotrue#74063