Skip to content

[6.0] [PackageCMO] Fixes linker issues for global addressor and class #73871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[6.0] [PackageCMO] Fixes linker issues for global addressor and class #73871

wants to merge 1 commit into from

Conversation

elsh
Copy link
Contributor

@elsh elsh commented May 24, 2024 •
edited
Loading

  • Explanation: Fixes linker issues for global addressor and class by keeping the decl's linkage if their defining module is built with allow_non_resilient_access flag.
  • Scope: Affects Package CMO only.
  • Original PR: Fix global accessor and class linker errors in package. #73686
  • Risk: Low. Changes are behind a flag and only affects Package CMO.
  • Testing: Added new tests.
  • Issue: rdar://127308331&128647016
  • Reviewer: @slavapestov

@elsh
Fix global accessor and class linker errors.
107ae0f 
Add global accessors to symbol list if VarDecl is fragile, i.e.
is non-resilient or its defining module allows non-resilient
access.

Don't set the class decl to hidden if it's in a package resilience
domain; even though its defining module is built resilently, the
class symbol should be visible across modules if they are in the
same package with resilience-bypass optimization. In such case,
treat its SubclassScope to Internal.

Resolves rdar://127321129
@elsh elsh requested a review from a team as a code owner May 24, 2024 00:41
@elsh
Copy link
Contributor Author

elsh commented May 24, 2024

@swift-ci test

@elsh
Copy link
Contributor Author

elsh commented May 30, 2024

Included in #73993

@elsh elsh closed this May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@elsh