Fix opaque type substitution in the package cmo resilience domain #73794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
elsh
reviewed
May 21, 2024
| @@ -188,6 +189,20 @@ public func mainPubArgRetInlinable(_ arg: PubKlass) -> PubStruct { | |||
| return PubStruct(arg.data) | |||
| } | |||
|
|
|||
| // CHECK-OPAQUE: sil @$s4Main023testPackageInSerializedC4FuncyyF : $@convention(thin) () -> () | |||
There was a problem hiding this comment.
Thanks for the fix! Could you create a new test file for this, like package-cmo-opaque-type? This file already contains too much and is getting harder to track all cases.
…nce domain rdar://128482863
aschwaighofer
force-pushed
the
package_cmo_opaque_type_subst
branch
from
bcd6f26 to
748b69d
Compare
|
@swift-ci test |
elsh
approved these changes
May 21, 2024
|
@swift-ci test |
elsh
reviewed
May 24, 2024
| // RUN: -module-name=Lib -package-name Pkg \ | ||
| // RUN: -parse-as-library -emit-module -emit-module-path %t/Lib.swiftmodule -I%t \ | ||
| // RUN: -Xfrontend -experimental-package-cmo -Xfrontend -experimental-allow-non-resilient-access \ | ||
| // RUN: -O -wmo -enable-library-evolution -Xfrontend -disable-availability-checking |
There was a problem hiding this comment.
Should we throw a proper diagnostics somewhere else so we don't need this -disable-availability-checking flag?
There was a problem hiding this comment.
No, this flag is used out of convenience, without it availability annotations would have to be used (because of opaque result types).
aschwaighofer
added a commit
to aschwaighofer/swift
that referenced
this pull request
May 24, 2024
…mo_opaque_type_subst Fix opaque type substitution in the package cmo resilience domain We need to serialize the underlying type if we want to see the underlying type accross the package resilience domain. rdar://128482863 (cherry picked from commit 58cc2a4) Risk: Low, should only affect package CMO mode rdar://128647016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to serialize the underlying type if we want to see the underlying type accross the package resilience domain.
rdar://128482863