Skip to content

[6.0][Tests] Remove erroneous swiftRemoteInspection dependency. #73592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2024

Conversation

al45tair
Copy link
Contributor

@al45tair al45tair commented May 13, 2024

This was added by #71839 as part of a fix for the TypeRoundTrip/round-trip.swift test, but it isn't necessary and it's breaking nightly builds.

rdar://128000843

This was added by swiftlang#71839 as part of a fix for the
`TypeRoundTrip/round-trip.swift` test, but it isn't necessary and
it's breaking nightly builds.

rdar://128000843
@al45tair al45tair added 🍒 release cherry pick Flag: Release branch cherry picks swift 6.0 labels May 13, 2024
@al45tair al45tair requested a review from a team as a code owner May 13, 2024 14:12
@al45tair
Copy link
Contributor Author

This is a cherry pick of #73591.

@al45tair
Copy link
Contributor Author

@swift-ci Please test

@al45tair al45tair enabled auto-merge May 13, 2024 19:00
@al45tair
Copy link
Contributor Author

Explanation: While trying to fix a test that uses Remote Mirror, I added a dependency to the tests, thinking that that was part of the fix. However, that dependency isn't needed and isn't right; it was harmless in PR testing, but with some other sets of build arguments it can result in a build failure.
Original PR: #73591
Risk: Low. This fixes a build failure.
Reviewed by: This was worth merging without review.
Resolves: rdar://128000843
Tests: This is a build fix for the tests.

@ktoso ktoso disabled auto-merge May 15, 2024 11:52
@ktoso ktoso changed the title [Tests] Remove erroneous swiftRemoteInspection dependency. [6.0][Tests] Remove erroneous swiftRemoteInspection dependency. May 15, 2024
@ktoso
Copy link
Contributor

ktoso commented May 15, 2024

Merging to unblock nightly toolchain builds.

@ktoso ktoso merged commit 6dfd4d0 into swiftlang:release/6.0 May 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants