[6.0][Concurrency] Fix too eager early return in checkIsolation mode detecting #73496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
changed the title
|
@swift-ci please test |
hborla
approved these changes
May 8, 2024
…ting If we have the ability to check env variables, and there was no env variable set we aggressively bailed out of the function's logic, without setting the executor mode at all. This prevented the dynamic modes from working in real (non testing) scenarios. Resolves rdar://127400013
ktoso
force-pushed
the
pick-wip-fix-checkIsCurrentExecutorMode
branch
from
99064c3 to
f650dc0
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: If we have the ability to check env variables, and there was no env variable set we aggressively bailed out of the function's logic, without setting the executor mode at all. This prevented the dynamic modes from working in real (non testing) scenarios.
Scope/Impact: Existing projects, compiled against old SDK would still trigger the new runtime check without this fix. This can break existing applications when user upgrades to new OS, and the application wasn't re-built/tested using the new stricter behavior.
Risk: Low, small change in handling null value
Testing: CI testing
Reviewed by: @mikeash
Original PR: #73495
Radar: rdar://127400013