Skip to content

[Const extract] Remove duplicate hasAttachedPropertyWrapper check #73456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jPaolantonio
Copy link
Contributor

@jPaolantonio jPaolantonio commented May 6, 2024

Removes a duplicate check of if (propertyDecl->hasAttachedPropertyWrapper()) introduced in #73261

This return is the same regardless of the if statement.

@jPaolantonio jPaolantonio requested review from artemcm and xedin May 6, 2024 16:41
@jPaolantonio jPaolantonio changed the title [Const extract[ Remove duplicate hasAttachedPropertyWrapper check [Const extract] Remove duplicate hasAttachedPropertyWrapper check May 6, 2024
Copy link
Contributor

@artemcm artemcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch. 😬

@artemcm
Copy link
Contributor

artemcm commented May 6, 2024

@swift-ci smoke test

@xedin xedin removed their request for review May 6, 2024 17:55
@jPaolantonio jPaolantonio merged commit b376408 into swiftlang:main May 8, 2024
3 checks passed
@jPaolantonio jPaolantonio deleted the eng/remove-duplicate-property-wrapper-check branch May 8, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants