[6.0] SILGen: Correct handling of subscripts with addressors. #73411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove improper special-case handling of subscripts in `findStorageReferenceExprForMoveOnly`. The correct thing to do for any storage decl ref of noncopyable type is to emit it as a borrow if it's implemented using storage, a read accessor, or an addressor. Fixes rdar://127335590.
|
@swift-ci Please test |
tbkka
approved these changes
May 8, 2024
kavon
approved these changes
May 10, 2024
Comment on lines
-3361
to
+3347
| storage = dyn_cast<VarDecl>(mre->getDecl().getDecl()); | ||
| storage = dyn_cast<AbstractStorageDecl>(mre->getDecl().getDecl()); | ||
| type = mre->getType(); | ||
| } else if (auto se = dyn_cast<SubscriptExpr>(result.getStorageRef())) { | ||
| storage = dyn_cast<AbstractStorageDecl>(se->getDecl().getDecl()); | ||
| type = se->getType(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Fixes a spurious move-only checking error when using
UnsafeBufferPointer's subscript as a borrowing parameter of noncopyable type.Scope: Bug fix.
Issue: rdar://127335590.
Original PR: #73410
Risk: Medium-low. The refactoring has a chance of affecting existing code using noncopyable types.
Testing: Swift CI, test case from bug report
Reviewer: @kavon