[SymbolGraphGen] Correctly handle exported imports in swift-symbolgraph-extract #73080
Conversation
daniel-grumberg
requested review from
QuietMisdreavus,
ahoppen,
bnbarham,
hamishknight,
rintaro,
hborla,
slavapestov,
xedin and
tshortli
as code owners
daniel-grumberg
changed the title
|
@swift-ci please test |
|
@swift-ci please smoke test |
…ymbolgraph-extract
daniel-grumberg
force-pushed
the
export-import-sgf-extract
branch
from
0246506 to
1d749b1
Compare
|
@swift-ci please smoke test |
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
lib/AST/Module.cpp
Outdated
| if (Recursive) { | ||
| ImportCollector importCollector; | ||
| this->getDisplayDeclsRecursivelyAndImports(Results, importCollector); | ||
| } | ||
| // FIXME: Should this do extra access control filtering? | ||
| FORWARD(getDisplayDecls, (Results)); |
There was a problem hiding this comment.
Make this an else branch
There was a problem hiding this comment.
Other than the comment we spotted while walking through the code, could you add a test that verifies that the recursive export-import functionality still works? There's a similar test in SymbolGraph/Module/ThirdOrder.swift that you can copy to make something similar. We just need to make sure that the innermost module's symbols appear in the outer symbol graph.
…cls for symbol graph generation This change is two fold. Firstly it enables collection of exported imports from non source file units. Additionally this recurses through the exported imports to ensure the transitive set is collected. Fixes swiftlang#59920 rdar://89687175
Ensure recursive calls to `ModuleDecl::getDisplayDecls` does not result in double collection of display decls.
daniel-grumberg
force-pushed
the
export-import-sgf-extract
branch
from
1d749b1 to
f152885
Compare
|
@swift-ci please smoke test |
|
@swift-ci please test |
Test is in |
…-sgf-extract [SymbolGraphGen] Correctly handle exported imports in swift-symbolgraph-extract
This sets up the necessary stuff to include symbols from exported imported modules in symbol graphs generated using the
swift-symbolgraph-extracttoolChanges include:
SourceFilefile units for the purpose ofModuleDecl::getDisplayDeclResolves #59920
rdar://89687175