[6.0] Disable SILCombine::visitInjectEnumAddrInst for empty tuple types #73022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci test |
kalebers
approved these changes
Apr 13, 2024
aschwaighofer
approved these changes
Apr 14, 2024
tbkka
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation:
SILCombine::visitInjectEnumAddrInstdeletesinit_enum_data_addrandinject_enum_addrand creates an empty value to store into the destination addr when legal. Optional empty types can be initialized withinit_enum_data_addrbutinject_enum_addrcan be present only on some control flow paths. Applying this optimization can result in uninitialized tag information on some paths leading to miscompilations.Issue: rdar://126231554
Scope: Effects optionals of empty type which are fairly common due to some frameworks
Risk: Low. Disabling an optimization recently enabled.
Testing: Unit tests
Reviewer: @aschwaighofer