AST: Fix availability checking for macros as default arguments #72813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshortli
requested review from
hborla,
ktoso,
slavapestov and
xedin
as code owners
Adoption of the `#isolation` macro as a default argument in the standard library exposed that the availbility of contents of default argument macro expansions were being mis-diagnosed. The nodes for auxilary files generated for default argument expansions were not being added to the enclosing file's `TypeRefinementContext` hierarchy, so the contents of the expansion would be diagnosed as if it were located in a context with the minimum availability for the compilation. Resolves rdar://125812256
tshortli
force-pushed
the
isolation-macro-availability
branch
from
86c1aa2 to
9058601
Compare
Contributor
Author
|
@swift-ci please test |
This was referenced Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adoption of the
#isolationmacro as a default argument in the standard library exposed that the availbility of contents of default argument macro expansions were being mis-diagnosed. The nodes for auxilary files generated for default argument expansions were not being added to the enclosing file'sTypeRefinementContexthierarchy, so the contents of the expansion would be diagnosed as if it were located in a context with the minimum availability for the compilation.Resolves rdar://125812256