Skip to content

[sil] Teach variable name utils how to handle init_existential_addr temporaries #72721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gottesmm merged 1 commit into from
Mar 30, 2024
Merged

[sil] Teach variable name utils how to handle init_existential_addr temporaries #72721

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions lib/SILOptimizer/Utils/VariableNameUtils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,14 @@ struct AddressWalkerState {
static SILValue
findRootValueForNonTupleTempAllocation(AllocationInst *allocInst,
AddressWalkerState &state) {
// These are instructions which we are ok with looking through when
// identifying our allocation. It must always refer to the entire allocation.
auto isAlloc = [&](SILValue value) -> bool {
if (auto *ieai = dyn_cast<InitExistentialAddrInst>(value))
value = ieai->getOperand();
return value == SILValue(allocInst);
};

// Walk from our allocation to one of our writes. Then make sure that the
// write writes to our entire value.
for (auto &inst : allocInst->getParent()->getRangeStartingAtInst(allocInst)) {
Expand All @@ -38,21 +46,21 @@ findRootValueForNonTupleTempAllocation(AllocationInst *allocInst,
continue;

if (auto *copyAddr = dyn_cast<CopyAddrInst>(&inst)) {
if (copyAddr->getDest() == allocInst &&
if (isAlloc(copyAddr->getDest()) &&
copyAddr->isInitializationOfDest()) {
return copyAddr->getSrc();
}
}

if (auto *si = dyn_cast<StoreInst>(&inst)) {
if (si->getDest() == allocInst &&
if (isAlloc(si->getDest()) &&
si->getOwnershipQualifier() != StoreOwnershipQualifier::Assign) {
return si->getSrc();
}
}

if (auto *sbi = dyn_cast<StoreBorrowInst>(&inst)) {
if (sbi->getDest() == allocInst)
if (isAlloc(sbi->getDest()))
return sbi->getSrc();
}

Expand Down
Loading