[region-isolation] Propagate global actor-ness of functions/closures. #72710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci smoke test |
Contributor
Author
|
Forgot to include the Input file for the test... :doh: |
ActorIsolation already has a "I have no value case": unspecified. Lets just use that. Just a mistake I made that I am trying to fix before anything further depends on this code.
I fixed a bunch of small issues around here that resulted in a bunch of radars being fixed. Specifically: 1. I made it so that we treat function_refs that are from an actor isolated function as actor isolated instead of sendable. 2. I made it so that autoclosures which return global actor isolated functions are treated as producing a global actor isolated function. 3. I made it so that we properly handle SILGen code patterns produced by Sendable GlobalActor isolated things. rdar://125452372 rdar://121954871 rdar://121955895 rdar://122692698
gottesmm
force-pushed
the
pr-feb1fe7a002640b270451f2187f141f4ed5da65d
branch
from
11a106e to
1cf4e99
Compare
Contributor
Author
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed a bunch of small issues around here that resulted in a bunch of radars
being fixed. Specifically:
I made it so that we treat function_refs that are from an actor isolated
function as actor isolated instead of sendable.
I made it so that autoclosures which return global actor isolated functions
are treated as producing a global actor isolated function.
I made it so that we properly handle SILGen code patterns produced by
Sendable GlobalActor isolated things.
rdar://125452372
rdar://121954871
rdar://121955895
rdar://122692698