AST/Frontend/stdlib: Fix condfails for NoncopyableGenerics and IsolatedAny #72608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshortli
requested review from
a team,
ahoppen,
bnbarham,
CodaFi,
DougGregor,
hamishknight,
rintaro,
hborla,
slavapestov and
xedin
as code owners
tshortli
force-pushed
the
non-copyable-generics-2
branch
from
cd1ca40 to
4ac9932
Compare
tshortli
force-pushed
the
non-copyable-generics-2
branch
3 times, most recently
from
04c4309 to
10e48cb
Compare
|
@swift-ci please smoke test |
… feature. The `.swiftinterface` of the standard library must remain compatible with some older compilers. Unfortunately, some of those older compilers do not allow the experimental feature `NoncopyableGenerics` to be enabled in production. To allow the stdlib to build with non-copyable generics enabled and still have the older compilers consume its interface, we have to use a new experimental feature identifier that they do not know about. Partially resolves rdar://125138945
…sed. When printing declarations with `NoncopyableGenerics2` suppressed we must avoid printing the `@_preInverseGenerics` attribute and any `borrowing` or `consuming` parameter ownership modifiers.
This prevents some re-declaration errors when building the standard library from its `.swiftinterface` with older compilers.
To preserve compatibility with older compilers that do not allow `IsolatedAny` to be enabled in production compilers, use an alias experimental feature when building the stdlib (`IsolatedAny2`). Also, add `@_allowFeatureSuppression(IsolatedAny)` in a couple spots it was forgotten. Partially resolves rdar://125138945
tshortli
force-pushed
the
non-copyable-generics-2
branch
from
10e48cb to
590d335
Compare
tshortli
changed the title
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
.swiftinterfaceof the standard library must remain compatible with some older compilers. Unfortunately, some of those older compilers do not allow the experimental featuresNoncopyableGenericsandIsolatedAnyto be enabled in production. To allow the stdlib to build with these features enabled and still have the older compilers consume its interface, we have to use new experimental feature identifiers that they do not know about.Additionally, some adjustments to feature suppression were needed for these features.
Partially resolves rdar://125138945