CI: Include stdlib build for Wasm in the Linux buildbot #72010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the WebAssembly stdlib build mandatory as part of PR testing.
|
@swift-ci smoke test |
|
@swift-ci smoke test |
1 similar comment
|
@swift-ci smoke test |
|
Looks like Wasm build adds about 12min: 2hr 3min (average of last 10 sucessful builds) -> 2hr 15min I think it's worth adding it to the Linux buildbot preset because we often forget to care 32-bit platforms not limited to Wasm even paying extra 12min. WDYT @MaxDesiatov @shahmishal ? |
shahmishal
approved these changes
Sep 13, 2024
|
Lets merge this with new run of CI testing because currently this configuration is failing to build in post merge CI |
|
@swift-ci smoke test |
|
@swift-ci build toolchain Linux |
MaxDesiatov
pushed a commit
that referenced
this pull request
Sep 20, 2024
) Reverts #72010, which causes a 1 hour regression in Linux build times. This is significantly higher than the original March numbers (~15 minutes). We should investigate where the extra time is coming from - possibly from the foundation and testing additions?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the WebAssembly stdlib build mandatory as part of PR testing.