Eytzingerize word break data #71731
Merged
Eytzingerize word break data #71731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci Please Apple Silicon benchmark |
Catfish-Man
force-pushed
the
ancient-austrian-technology-2
branch
from
1abbaee to
59f1af8
Compare
Contributor
Author
|
@swift-ci Please Apple Silicon benchmark |
Catfish-Man
force-pushed
the
ancient-austrian-technology-2
branch
from
59f1af8 to
e9492e9
Compare
Contributor
Author
|
@swift-ci Please Apple Silicon benchmark |
Azoy
approved these changes
Feb 19, 2024
Contributor
Azoy
left a comment
Azoy
left a comment
There was a problem hiding this comment.
LGTM, but I doubt the benchmarks will come up with anything useful because this is only exercised in the regex work.
Catfish-Man
force-pushed
the
ancient-austrian-technology-2
branch
from
e9492e9 to
ecc6360
Compare
Contributor
Author
|
@swift-ci please benchmark |
Contributor
Author
|
Results from the new benchmark on my machine: Before: After: |
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
Build failure should be fixed by swiftlang/swift-package-manager#7350 |
Contributor
Author
|
@swift-ci please test macOS platform |
1 similar comment
Contributor
Author
|
@swift-ci please test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rdar://123278973