[AST/Sema] NonCopyableGenerics: Address some of the request circularity issues #71659
+339
−356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kavon
approved these changes
Feb 15, 2024
xedin
force-pushed
the
noncopyable-circularity-fixes
branch
from
4f493a4 to
f53d7a2
Compare
|
@swift-ci please test |
|
@swift-ci please test |
…traint is an `InverseTypeRepr` This avoid a cycle in recursive and invalid code where one of the requirements references the subject type.
…s placed on Self of protocol
…invertible protocol
The method only needs to know about the presence of inverses for the given invertiable protocol.
…of found inverse
…rking` The first step on the path to dismangle `TypeDecl::getMarking()`.
Introduce `NominalTypeDecl::has{Marking, InverseMarking}` methods
that split the logic from `InvertibleAnnotationRequest`
…Decl::hasInverseMarking` TypeRepr for the subject should be already bound to a generic type declaration, so there is no need to resolve the requirement to check that.
…ciated type declarations This is required for `ASTPrinter` to wrap the protocol that has associated type with inverses in a feature block.
…le} to `NominalTypeDecl`
xedin
force-pushed
the
noncopyable-circularity-fixes
branch
from
9ebc57f to
b6af269
Compare
|
@swift-ci please test |
|
Please test with following pull request: @swift-ci please test Linux platform |
|
@swift-ci please test Linux |
|
@swift-ci please test macOS platform |
|
@swift-ci please clean test macOS platform |
|
@swift-ci please smoke test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InvertibleAnnotationRequest