Bincompat hooks for revised hash/isEqual interop #71620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds in hooks so that the new hash/isEqual interop (which bridges Obj-C hash/isEqual: calls to the corresponding Swift Hashable/Equatable conformances) can be selectively disabled based on the OS and/or client. For now, enable the new semantics everywhere except Apple platforms (which have legacy apps that may be relying on the old semantics).
|
@swift-ci Please test |
mikeash
approved these changes
Feb 14, 2024
|
@swift-ci Please test |
al45tair
approved these changes
Feb 15, 2024
tbkka
commented
Feb 22, 2024
| @@ -458,6 +464,11 @@ - (NSUInteger)hash { | |||
| selfHeader->type, hashableConformance); | |||
| } | |||
|
|
|||
| if (!runtime::bincompat::useLegacySwiftObjCHashing()) { | |||
There was a problem hiding this comment.
Darn. That ! should not have been there... Follow-up PR will fix this.
There was a problem hiding this comment.
Ouch. Lots of trouble from a line and a dot.
tbkka
added a commit
to tbkka/swift
that referenced
this pull request
Feb 23, 2024
Github PR swiftlang#71620 mixed up one of the bincompat conditionals. It also had some errors in the tests for ObjC interop. For now, this leaves the legacy behavior in place for all Apple platforms.
tbkka
added a commit
to tbkka/swift
that referenced
this pull request
Feb 28, 2024
Github PR swiftlang#71620 mixed up one of the bincompat conditionals. It also had some errors in the tests for ObjC interop. For now, this leaves the legacy behavior in place for all Apple platforms.
tbkka
added a commit
to tbkka/swift
that referenced
this pull request
May 9, 2024
PR swiftlang#71620 made this behavior conditional as a way to help provide binary compatibility for legacy software that might be relying on the old behavior. So far, it appears the only such problems arose from the SwiftObject behavior changes, not from SwiftValue behavior. So let's optimistically back this out and make the new behavior unconditional. Resolves rdar://127839540
This was referenced May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds in hooks so that the new hash/isEqual interop (which bridges Obj-C hash/isEqual: calls to the corresponding Swift Hashable/Equatable conformances) can be selectively disabled based on the OS and/or client.
For now, enable the new semantics everywhere except Apple platforms (which have legacy apps that may be relying on the old semantics).
Resolves: rdar://121399248