Sema: Associated type inference regressions, round 4 #71575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
force-pushed
the
assoc-type-regression-fixes-4
branch
from
20d9838 to
2e72c9a
Compare
slavapestov
changed the title
slavapestov
force-pushed
the
assoc-type-regression-fixes-4
branch
2 times, most recently
from
c3f9dad to
9b01dad
Compare
slavapestov
requested review from
AnthonyLatsis,
hborla and
xedin
as code owners
slavapestov
force-pushed
the
assoc-type-regression-fixes-4
branch
from
db8eb4f to
ff50a95
Compare
slavapestov
force-pushed
the
assoc-type-regression-fixes-4
branch
from
ff50a95 to
80e8441
Compare
|
@swift-ci Please test source compatibility |
…e-inference This just brings back a bunch of old brittle logic conditionalized on the negation of the flag. Fixes rdar://problem/122810266.
…ental-associated-type-inference The funny indentation will make the diff easier to read once we remove the staging flag.
Instead of computing the reduced type of the witness upfront and then checking for canonical equality in type matching, check for reduced equality in type matching. This restores the old behavior and prevents us from considering too many protocol extension witnesses, while fixing the request cycle that motivated the change to instead match against the reduced type of the witness. Fixes rdar://problem/122589094, rdar://problem/122596633.
slavapestov
force-pushed
the
assoc-type-regression-fixes-4
branch
from
80e8441 to
c34a74c
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rdar://problem/122589094, rdar://problem/122596633, and rdar://problem/122810266.
There is a bunch of new code in
AssociatedTypeInference.cppconditionalized on the new flag. Also to minimize breakage with the flag off I restored some old code behind the negation of the flag. The file looks messy right now but the structure will become apparent once the old code is gone.