[Observation] Add generation for _modify to fields such that we avoid extra CoW
#71122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests for validation incoming soon. |
phausler
force-pushed
the
pr/observation_modify_access
branch
2 times, most recently
from
2868dd9
to
4ea8946
Compare
|
@swift-ci please test |
dduan
approved these changes
Jan 25, 2024
phausler
force-pushed
the
pr/observation_modify_access
branch
from
4ea8946
to
34c0417
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the emission of the
@Observablemacro such that the field generation has an additional_modifyaccessor. Doing this avoids the potentially quadratic access for collection types and does in-place mutation. Provisionally this seems to have no adverse behavioral impact with interoperation of existing observation systems.Resolves the following issues:
rdar://121161889
FB13547947