Sema: Allow _diagnoseUnavailableCodeReached() to not exist in the stdlib #70749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lib. Sometimes the compiler may need to build with an out-of-date standard library and we can't assume recently added well-known declarations are present. When synthesizing Hashable and Equatable conformances, if `_diagnoseUnavailableCodeReached()` isn't present then just generate the body of the case normally instead. This isn't ideal, but there isn't any existing infrastructure to generate a call to `fatalError()` at the AST level and this should be a rare edge case where we're simply falling back to the previous behavior where unavailable cases weren't handled at all. No tests because it isn't straight forward to compile with an intentionally broken standard library that's missing some declarations. Resolves rdar://120554183
Contributor
Author
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the compiler may need to build with an out-of-date standard library and we can't assume recently added well-known declarations are present. When synthesizing Hashable and Equatable conformances, if
_diagnoseUnavailableCodeReached()isn't present then just generate the body of the case normally instead. This isn't ideal, but there isn't any existing infrastructure to generate a call tofatalError()at the AST level and this should be a rare edge case where we're simply falling back to the previous behavior where unavailable cases weren't handled at all.No tests because it isn't straight forward to compile with an intentionally broken standard library that's missing some declarations.
Resolves rdar://120554183