[OpaqueValues] Assign tuple into tuple-typed memory. #70738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The instruction exists to express the atomic initialization of a tuple-typed address in address-lowered mode. In opaque-values mode, this is expressed as an assign/store.
In address-lowered mode, to initialize tuple-typed memory in a single step, tuple_addr_constructor must generally be used because it's not possible to construct a tuple any of whose fields are address-only. In opaque values mode, there is no problem constructing such a tuple. So construct the tuple and then assign it into the tuple-typed memory; the single instruction that initializes the memory will be the assign.
Contributor
Author
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In address-lowered mode, to initialize tuple-typed memory in a single step,
tuple_addr_constructormust generally be used because it's not possible to construct a tuple any of whose fields are address-only. In opaque values mode, there is no problem constructing such a tuple. So construct the tuple and then assign it into the tuple-typed memory; the single instruction that initializes the memory will be theassign.