ObjectOutliner: support outlining of classes in global let variables #70684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eeckstein
requested review from
hborla,
slavapestov,
xedin,
ahoppen,
bnbarham,
CodaFi,
DougGregor,
hamishknight and
rintaro
as code owners
eeckstein
requested review from
atrick,
meg-gupta and
nate-chandler
and removed request for
xedin,
slavapestov,
rintaro,
DougGregor,
bnbarham,
CodaFi,
ahoppen,
hborla and
hamishknight
|
@swift-ci test |
|
@swift-ci benchmark |
karwa
reviewed
Jan 3, 2024
SwiftCompilerSources/Sources/Optimizer/FunctionPasses/ObjectOutliner.swift
Outdated
Show resolved
Hide resolved
eeckstein
force-pushed
the
static-objects
branch
from
792bca7 to
cdb0364
Compare
|
@swift-ci test |
eeckstein
force-pushed
the
static-objects
branch
from
cdb0364 to
772d059
Compare
|
@swift-ci test |
eeckstein
force-pushed
the
static-objects
branch
from
772d059 to
9c62787
Compare
|
@swift-ci test |
Currently only arrays can be put into a read-only data section. "Regular" classes have dynamically initialized metadata, which needs to be stored into the isa field at runtime.
Optionally, the dependency to the initialization of the global can be specified with a dependency token `depends_on <token>`. This is usually a `builtin "once"` which calls the initializer for the global variable.
It notifies the pass manager that the optimization result of the current pass depends on the body (i.e. SIL instructions) of another function than the currently optimized one.
…tils * `var Function.initializedGlobal` * `func getGlobalInitialization` and add `var CollectionLikeSequence.singleElement`
Inline the initialization code of a global initializer if the load is a global_addr with a builtin "once" dependency.
``` let c = SomeClass() ``` is turned into ``` private let outlinedVariable = SomeClass() // statically initialized and allocated in the data section let c = outlinedVariable ``` rdar://111021230 rdar://115502043 Also, make the ObjectOutliner work for OSSA. Though, it currently doesn't run in the OSSA pipeline.
eeckstein
force-pushed
the
static-objects
branch
from
9c62787 to
fa3a959
Compare
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is turned into
rdar://111021230
rdar://115502043
This requires a change in SIL: add a dependency token operand to
global_addrOptionally, the dependency to the initialization of the global can be specified with a dependency token
depends_on <token>.This is usually a
builtin "once"which calls the initializer for the global variable.