Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/Sema/TypeCheckConcurrency.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2628,7 +2628,7 @@ namespace {
auto value = valueRef.getDecl();
auto loc = declRef->getLoc();

//FIXME: Should this be subsumed in reference checking?
// FIXME: Should this be subsumed in reference checking?
if (value->isLocalCapture())
checkLocalCapture(valueRef, loc, declRef);
else
Expand Down
2 changes: 1 addition & 1 deletion stdlib/public/core/Set.swift
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,7 @@ extension Set: Collection {
/// Accesses the member at the given position.
@inlinable
public subscript(position: Index) -> Element {
//FIXME(accessors): Provide a _read
// FIXME(accessors): Provide a _read
get {
return _variant.element(at: position)
}
Expand Down
2 changes: 1 addition & 1 deletion stdlib/public/core/SmallString.swift
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ extension _SmallString {
) {
_internalInvariant(index > 0)
_internalInvariant(index <= _SmallString.capacity)
//FIXME: Verify this on big-endian architecture
// FIXME: Verify this on big-endian architecture
let mask0 = (UInt64(bitPattern: ~0) &>> (8 &* ( 8 &- Swift.min(index, 8))))
let mask1 = (UInt64(bitPattern: ~0) &>> (8 &* (16 &- Swift.max(index, 8))))
storage.0 &= (index <= 0) ? 0 : mask0.littleEndian
Expand Down
4 changes: 2 additions & 2 deletions test/Serialization/Inputs/def_basic.sil
Original file line number Diff line number Diff line change
Expand Up @@ -1065,8 +1065,8 @@ sil [transparent] [serialized] @test_mark_fn_escape : $@convention(thin) () -> (
%c = alloc_box $<τ_0_0> { var τ_0_0 } <Int>
%ca = project_box %c : $<τ_0_0> { var τ_0_0 } <Int>, 0

//mark_function_escape %ba : $*Int
//mark_function_escape %ba : $*Int, %ca : $*Int
// mark_function_escape %ba : $*Int
// mark_function_escape %ba : $*Int, %ca : $*Int

%28 = tuple ()
return %28 : $()
Expand Down
2 changes: 1 addition & 1 deletion tools/SourceKit/tools/sourcekitd-test/TestOptions.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -494,7 +494,7 @@ bool TestOptions::parseArgs(llvm::ArrayRef<const char *> Args) {
void TestOptions::printHelp(bool ShowHidden) const {

// Based off of swift/lib/Driver/Driver.cpp, at Driver::printHelp
//FIXME: should we use IncludedFlagsBitmask and ExcludedFlagsBitmask?
// FIXME: should we use IncludedFlagsBitmask and ExcludedFlagsBitmask?
// Maybe not for modes such as Interactive, Batch, AutolinkExtract, etc,
// as in Driver.cpp. But could be useful for extra info, like HelpHidden.

Expand Down
2 changes: 1 addition & 1 deletion validation-test/stdlib/ArraysObjc.swift.gyb
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,7 @@ ArrayTestSuite.test("BridgedFromObjC.Nonverbatim.ImmutableArrayIsCopied") {
CustomImmutableNSArray.timesCountWasCalled = 0
TestBridgedValueTy.bridgeOperations = 0
let a: [TestBridgedValueTy] = convertNSArrayToArray(nsa)
//FIXME: Why is this copied?
// FIXME: Why is this copied?
expectEqual(1, CustomImmutableNSArray.timesCopyWithZoneWasCalled)
expectEqual(3, CustomImmutableNSArray.timesObjectAtIndexWasCalled)
expectNotEqual(0, CustomImmutableNSArray.timesCountWasCalled)
Expand Down