[Macros] Don't apply member attribute macros to accessors #70435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accessors are conceptually nested within their property or subscript declarations, so member-attribute macros should only apply to the property or subscript declarations. This eliminates what appears to be redundant macro expansion. Fixes rdar://118956800.
DougGregor
requested review from
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please smoke test |
This was referenced Jan 4, 2024
kastiglione
added a commit
that referenced
this pull request
Jan 8, 2024
This workaround is no longer needed, as of #70435.
Catfish-Man
pushed a commit
to Catfish-Man/swift
that referenced
this pull request
Jan 19, 2024
) This workaround is no longer needed, as of swiftlang#70435.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accessors are conceptually nested within their property or subscript declarations, so member-attribute macros should only apply to the property or subscript declarations. This eliminates what appears to be redundant macro expansion.
Fixes rdar://118956800.