Skip to content

[Explicit Moduele Builds] Look through forwarding modules for canImport version check. #70335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented Dec 8, 2023

Otherwise we default to version 0 for all modules which get forwarded.

Resolves rdar://119346213

…ort' version check.

Otherwise we default to version 0 for all modules which get forwarded.

Resolves rdar://119346213
@artemcm artemcm requested review from xymus, owenv and nkcsgexi December 8, 2023 23:21
@artemcm artemcm requested a review from tshortli as a code owner December 8, 2023 23:21
@artemcm
Copy link
Contributor Author

artemcm commented Dec 8, 2023

@swift-ci smoke test

Copy link
Contributor

@nkcsgexi nkcsgexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@artemcm artemcm enabled auto-merge December 8, 2023 23:24
import Bar
#endif

// 'Bar' can only be imported if the explicitly-loaded 'Foo' is known to be over 9000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's Over 9000!

@artemcm artemcm merged commit 1a60dae into swiftlang:main Dec 9, 2023
@artemcm artemcm deleted the DepScanSkipSwiftDependencyClangSearchPaths branch December 11, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants