[AST] Remove static loc and spelling kind from AccessorDecl #70326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The spelling kind was only ever set to `StaticSpellingKind::None`, and the static location was never used for anything (and should be queried on the storage anyway). This doesn't affect the computation of `isStatic` since `IsStaticRequest` already takes the static-ness from the storage for accessors.
hamishknight
requested review from
slavapestov,
hborla,
xedin,
ahoppen,
bnbarham,
CodaFi,
DougGregor,
rintaro,
zoecarver,
hyp and
egorzhdan
as code owners
|
@swift-ci please test |
rintaro
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spelling kind was only ever set to
StaticSpellingKind::None, and the static location was never used for anything (and should be queried on the storage anyway). This doesn't affect the computation ofisStaticsinceIsStaticRequestalready takes the static-ness from the storage for accessors.