Skip to content

Revert "Don't require a strict revision match in LLDB." #70274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

adrian-prantl
Copy link
Contributor

This reverts commit 3cc2831.

The compiler's revision check has been relaxed since the feature was introduced and so it's nos better to reduce the number of special code paths for LLDB in the compiler to facilitate reasoning about it.

rdar://117824367

@adrian-prantl adrian-prantl requested review from xymus and removed request for artemcm and tshortli December 6, 2023 19:00
@adrian-prantl
Copy link
Contributor Author

@swift-ci test

This reverts commit 3cc2831.

The compiler's revision check has been relaxed since the feature was introduced
and so it's nos better to reduce the number of special code paths for LLDB in
the compiler to facilitate reasoning about it.

rdar://117824367
@adrian-prantl
Copy link
Contributor Author

@swift-ci test

@adrian-prantl
Copy link
Contributor Author

test with swiftlang/llvm-project#7851
@swift-ci test

Copy link
Contributor

@xymus xymus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@adrian-prantl adrian-prantl merged commit 3b38e15 into swiftlang:main Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants