Function body macros #70034
Merged
Function body macros #70034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
|
@swift-ci please build toolchain |
Function body macros allow one to introduce a function body for a particular function, either providing a body for a function that doesn't have one, or wholesale replacing the body of a function that was written with a new one.
Implement type checking support for preamble macros, which expands the preamble macros and introduces them at the beginning of the function body prior to type checking. Ensure that the resulting function bodies type-check properly, including when composing multiple preamble macros and with a preamble macro applied to the body of a function that itself came from a body macro.
DougGregor
force-pushed
the
function-body-macros
branch
from
5bac07b to
380bad4
Compare
|
@swift-ci please smoke test |
|
@swift-ci please build toolchain |
|
@swift-ci please test macOS |
|
@swift-ci please test Windows |
DougGregor
requested review from
ahoppen,
bnbarham,
rintaro,
hborla,
slavapestov,
xedin,
CodaFi,
hamishknight,
zoecarver and
tshortli
as code owners
|
I think this is in good-enough shape to land, so I've gone ahead and merged it. I'll iterate on the implementation on main alongside the discussions of the proposal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce function body macros, which are comprised of two similar macro roles: