Remove two pImpl abstraction layers in rename #69783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…angesAnnotatingConsumer`
ahoppen
requested review from
bnbarham,
rintaro and
hamishknight
as code owners
|
@swift-ci Please smoke test |
rintaro
approved these changes
Nov 10, 2023
bnbarham
approved these changes
Nov 10, 2023
| @@ -24,12 +24,13 @@ | |||
| #include "swift/AST/DiagnosticConsumer.h" | |||
| #include "swift/AST/PluginRegistry.h" | |||
| #include "swift/Basic/ThreadSafeRefCounted.h" | |||
| #include "swift/Frontend/PrintingDiagnosticConsumer.h" | |||
There was a problem hiding this comment.
This would be an example of why it can be useful, though it probably doesn't really matter in this case (ie. the header is really only needed in the implementation, but now slows down everything including SwiftLangSupport.h)
bnbarham
reviewed
Nov 10, 2023
| @@ -100,13 +100,11 @@ class FindRenameRangesConsumer { | |||
| }; | |||
|
|
|||
| class FindRenameRangesAnnotatingConsumer : public FindRenameRangesConsumer { | |||
| struct Implementation; | |||
| Implementation &Impl; | |||
| std::unique_ptr<SourceEditConsumer> pRewriter; | |||
There was a problem hiding this comment.
I realize you just moved this out, but... odd name.
hamishknight
approved these changes
Nov 13, 2023
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMO the code is a lot easier to read if we don’t hide the implementation in an
Implementationclass. AFAICT the abstraction layer wasn’t giving us anything.