Skip to content

[build] Respect DEPLOYMENT_VERSION_{IOS|TVOS|WATCHOS} for Swift sources #69670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2023
Merged

[build] Respect DEPLOYMENT_VERSION_{IOS|TVOS|WATCHOS} for Swift sources #69670

merged 1 commit into from
Nov 7, 2023

Conversation

egorzhdan
Copy link
Contributor

See #69512

rdar://117699474

@egorzhdan egorzhdan added the c++ interop Feature: Interoperability with C++ label Nov 6, 2023
@egorzhdan egorzhdan requested review from etcwilde and hyp November 6, 2023 16:21
@egorzhdan egorzhdan requested a review from a team as a code owner November 6, 2023 16:21
@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test

hyp
hyp approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@hyp hyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@egorzhdan egorzhdan merged commit 0db93e2 into main Nov 7, 2023
@egorzhdan egorzhdan deleted the egorzhdan/cmake-deployment-target branch November 7, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyp hyp hyp approved these changes

@etcwilde etcwilde Awaiting requested review from etcwilde

Assignees
No one assigned
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@egorzhdan @hyp