[5.10][Concurrency] Isolated static lets are not safe to access across actors.
#69607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tors. (cherry picked from commit 8eab5fe)
Member
Author
|
@swift-ci please test |
…tors. (cherry picked from commit 04be278)
Member
Author
|
@swift-ci please test |
Member
Author
|
@swift-ci please test |
tbkka
approved these changes
Nov 6, 2023
nkcsgexi
approved these changes
Nov 6, 2023
DougGregor
requested changes
Nov 6, 2023
|
|
||
| // Static 'let's are initialized upon first access, so they cannot be | ||
| // synchronously accessed across actors. | ||
| if (var->isGlobalStorage() && var->isLazilyInitializedGlobal()) |
Member
There was a problem hiding this comment.
I think this rule prohibits reasonable code from working and would like to discuss it further before merging.
Member
There was a problem hiding this comment.
@hborla has clarified that I misread the code, and this is already appropriate narrow in applicability.
DougGregor
approved these changes
Nov 6, 2023
|
|
||
| // Static 'let's are initialized upon first access, so they cannot be | ||
| // synchronously accessed across actors. | ||
| if (var->isGlobalStorage() && var->isLazilyInitializedGlobal()) |
Member
There was a problem hiding this comment.
@hborla has clarified that I misread the code, and this is already appropriate narrow in applicability.
Member
Author
|
@swift-ci please test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lets synchronously across actors was being applied tostaticvariables. However,static letvariables are initialized upon first access, so synchronously accessing them across actors can lead to data races.letvariables that are lazily initialized.expression is 'async' but is not marked with 'await'if it accesses an isolatedstatic letfrom across isolation boundaries withoutawait.static lets are not safe to access across actors. #69598, [Concurrency] Isolated globallets are not safe to access across actors. #69616