NFC: Subset out floating point raw value enum parsing tests #69574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test/Parse/enum.swift test was only enabled for Intel platforms because a few of the contained test cases relied on floating point literal parsing and were not portable as a result. Subset out the non-portable test cases into a new test so that more general enum parsing tests can run on all platforms.
tshortli
requested review from
CodaFi,
DougGregor,
ahoppen,
bnbarham and
rintaro
as code owners
Contributor
Author
|
@swift-ci please test |
ahoppen
approved these changes
Nov 1, 2023
CodaFi
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test/Parse/enum.swift test was only enabled for Intel platforms because a few of the contained test cases relied on floating point literal parsing and were not portable as a result. Subset out the non-portable test cases into a new test so that more general enum parsing test cases can run on all platforms.