🍒[5.10][Concurrency] Un-deprecate enqueue(UnownedJob) for easier adoption #69533
+10
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this deprecation emitted by the compiler some codebases that support many old Swift versions have been forced into warnings they cannot avoid due to the compatibility promises they made. This removes the warning but changes no functionality.
ktoso
changed the title
|
@swift-ci please test |
FranzBusch
approved these changes
Oct 31, 2023
|
CI on macos is broken with when that's fixed this should be re-run and merged |
|
@swift-ci please test |
|
@swift-ci please test Windows |
hborla
approved these changes
Nov 1, 2023
|
Thank you! Merging, hope this helps adoption without warnings @FranzBusch :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: We were emitting a custom deprecation about the
enqueue(UnownedJob)in order to nudge people to use the move-only ExecutorJob. With this deprecation emitted by the compiler some codebases that support many old Swift versions have been forced into warnings they cannot avoid due to the compatibility promises they made.The
UnownedJobnever was deprecated, so no change to it.Risk: Low, only a deprecation removal.
Impact: This removes the warning but changes no functionality. Helps projects adopting custom executors but having to support old Swift versions avoid compile warnings.
Original PR: #69532
Review by: @FranzBusch
Radar: rdar://117123460