[ASTGen] NFC: Format with swift-format #69325
Conversation
This uses the same formatting configuration as sourcekit-lsp.
|
@swift-ci please smoke test |
hamishknight
added
the
ASTGen
| @@ -0,0 +1,17 @@ | |||
| { | |||
| "version": 1, | |||
| "lineLength": 120, | |||
There was a problem hiding this comment.
FYI we settled on aiming for 160 here, which motivated swiftlang/swift-syntax#1714.
How about a symlink to the swift-syntax configuration file for everything inside lib instead? Consistent formatting across our Swift repos sounds really nice.
There was a problem hiding this comment.
I'll let @ahoppen confirm, but AFAIK we want to standardize on 120 swiftlang/sourcekit-lsp#890 (comment)
There was a problem hiding this comment.
but AFAIK we want to standardize on 120
Oh, that’s new. Totally fine by me! I still incline to a symlink until swift-syntax transitions though. I’m wondering what we can do to standardize the Swift formatting in these repositories without having to maintain multiple config files.
There was a problem hiding this comment.
Yes, we agreed to use 120 columns. We should update swift-syntax to 120 as well at some point but I haven’t gotten to it yet.
I still incline to a symlink until swift-syntax transitions though
If we were to symlink swift-syntax’s config file to swift, it means that you can’t work on swift-syntax as a standalone package anymore. Similar for sourcekit-lsp. I think the best thing to do, is to have a separate config file in each repo and add a CI check that all the config files are the same.
There was a problem hiding this comment.
If we were to symlink swift-syntax’s config file to swift, it means that you can’t work on swift-syntax as a standalone package anymore.
I meant the symlink to be in the swift repository and link to the swift-syntax or sourcekit-lsp config file.
I think the best thing to do, is to have a separate config file in each repo and add a CI check that all the config files are the same.
Alternatively, maybe we could create a special repo to host this kind of stuff and add it as a git submodule to other repos. Then each repo can replace their own config files with symlinks to the config files in that submodule.
| @@ -0,0 +1,17 @@ | |||
| { | |||
| "version": 1, | |||
| "lineLength": 120, | |||
There was a problem hiding this comment.
Yes, we agreed to use 120 columns. We should update swift-syntax to 120 as well at some point but I haven’t gotten to it yet.
I still incline to a symlink until swift-syntax transitions though
If we were to symlink swift-syntax’s config file to swift, it means that you can’t work on swift-syntax as a standalone package anymore. Similar for sourcekit-lsp. I think the best thing to do, is to have a separate config file in each repo and add a CI check that all the config files are the same.
|
Merging so I can base #69326 on main, will do a follow-up for the formatting fixups |
|
Opened #69336 for the formatting tweaks |
This uses the same formatting configuration as sourcekit-lsp.