[android][test] Fix five tests that are failing on the community Android CI #69189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oid CI Update the Android doc with info about the latest LTS NDK not working.
finagolfin
commented
Oct 14, 2023
| @@ -9,7 +9,7 @@ import Constructors | |||
| import TypeClassification | |||
|
|
|||
| public func createHasVirtualBase() -> HasVirtualBase { | |||
| // ITANIUM_ARM: define protected swiftcc void @"$s7MySwift20createHasVirtualBaseSo0deF0VyF"(ptr noalias nocapture sret({{.*}}) %0) | |||
| // ITANIUM_ARM: define protected swiftcc void @"$s7MySwift20createHasVirtualBaseSo0deF0VyF"(ptr noalias sret({{.*}}) %0) | |||
There was a problem hiding this comment.
As done for many other tests in #68481
finagolfin
commented
Oct 14, 2023
| // CHECK: @"${{s4main1pSo0042MagicArrayCInt_CUnsignedLong_2_DFABlHknrCcVvp|s4main1pSo0047MagicArrayCInt_CUnsignedLongLong_2_ofBJmlmartjdVvp}}" | ||
| // CHECK: @"${{s4main1tSo0042MagicArrayCInt_CUnsignedLong_3_DFABlHknrCcVvp|s4main1tSo0047MagicArrayCInt_CUnsignedLongLong_3_ofBJmlmartjdVvp}}" | ||
| // CHECK: @"${{s4main1pSo0042MagicArrayCInt_CUnsignedLong_2_DFABlHknrCcVvp|s4main1pSo0047MagicArrayCInt_CUnsignedLongLong_2_ofBJmlmartjdVvp|s4main1pSo0041MagicArrayCInt_CUnsignedInt_2_yDFGkvkBqzcVvp}}" | ||
| // CHECK: @"${{s4main1tSo0042MagicArrayCInt_CUnsignedLong_3_DFABlHknrCcVvp|s4main1tSo0047MagicArrayCInt_CUnsignedLongLong_3_ofBJmlmartjdVvp|s4main1tSo0041MagicArrayCInt_CUnsignedInt_3_yDFGkvkBqzcVvp}}" |
There was a problem hiding this comment.
This only fails on armv7, can simply disable it there instead if wanted.
finagolfin
commented
Oct 14, 2023
| @@ -19,30 +19,33 @@ public func charArray(_ i: Int) -> [Character] { | |||
|
|
|||
| // NOTE: 97 = 'a' | |||
| // NOTE: -2233785415175766016 = 0xE1 = 0xE0 (ASCII discrim) | 0x01 (count) | |||
| // NOTE: On Android AArch64, this is shifted right by one byte: 0x00E1 = 63331869759897600 | |||
There was a problem hiding this comment.
A direct consequence of #40779
|
@swift-ci please test |
|
@drodriguez, passed CI, ready for review and merge. |
|
Great, Android CI is green again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the Android doc with info about the latest LTS NDK not working.
@drodriguez, this should get the Android CI passing again.