[5.9] Enable macros on Windows #68692
Conversation
Use WiX to extract a future toolchain to allow building the macros support when building the toolchain. We build swift-syntax and now wire that into the build itself.
try a more recent toolchain
After swiftlang/llvm-project@05d613e 17 tests started to fail on Windows when when the SOURCE_DIR is on a substitute drive due to the path expansion difference. This fixes 7 of these tests.
|
swiftlang/swift-installer-scripts#246 @swift-ci please build toolchain windows platform |
|
swiftlang/llvm-project#7513 @swift-ci please build toolchain windows platform |
|
@tristanlabelle any idea what's going on with the test failures here? It seems to be the |
|
The tests failures seem to be what I was fixing in #68124 . Unfortunately the conclusion from that PR was that the approach was not the right one. I'm working on implementing a better fix now (wrapping the virtual filesystem on Windows to enforce drive preservation). I can code it in the Swift repo to unblock things faster, but ideally it would go into LLVM. |
I assume that implies that the substitution isn't happening on IIUC @compnerd included it thinking it may fix some foundation test failures, but it doesn't look like we're ready to include in 5.9. So maybe the best path forward is removing the substitution and then working out the foundation failures? |
|
I'm also uneasy with having the drive substitution only in 5.9 if it's causing test regressions. I would rather have time to fix those on main. Let's see what comes out of #68743 but if I recall, the problem there was that we had one path that reached MAX_PATH by one or two characters :/ |
😭 If that's a test path, maybe we can just update the name. Shall see soon! |
Use WiX to extract a future toolchain to allow building the macros support when building the toolchain. We build swift-syntax and now wire that into the build itself.