test: Disable access merging optimization test with invariant asserts #68538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kateinoigakukun
changed the title
kateinoigakukun
force-pushed
the
katei/disable-opt-test-cow-check
branch
from
bc7ff09 to
e496924
Compare
|
@swift-ci Please smoke test |
|
preset=buildbot_incremental_linux_crosscompile_wasm |
Invariant checks add extra access markers and they made the optimized code different than the expected one and made the test failed. CI presets usually set `--no-swift-stdlib-assertion`, so no effect on CI except for `buildbot_incremental_linux_crosscompile_wasm`.
kateinoigakukun
force-pushed
the
katei/disable-opt-test-cow-check
branch
from
e496924 to
e5b2348
Compare
|
It proved to repair the preset build with the depending cmake change: https://ci.swift.org/job/swift-PR-Linux-preset/71/, rebasing onto main. |
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invariant checks add extra access markers and they made the optimized code different than the expected one and made the test failed. CI presets usually set
--no-swift-stdlib-assertion, so no effect on CI except forbuildbot_incremental_linux_crosscompile_wasm.