Minor improvements to the new diagnostics formatter #68289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "grouped diagnostics" feature can handle multiple warnings/errors/remarks in a single grouping, but doing so isn't very ergonomic for users because the primary warning/error/remark can be buried in the source file. As a first step toward improving this situation, always break up groups at a new warning/error/remark.
|
@swift-ci please smoke test |
|
swiftlang/swift-syntax#2143 @swift-ci please smoke test macOS |
We'll be using the new swift-syntax diagnostic formatter in the near future, as it is nearly available on all host platforms. So, remove the C++ formatter that did source-line annotation, falling back to the "LLVM" style when swift-syntax is not compiled in.
|
swiftlang/swift-syntax#2143 @swift-ci please smoke test |
|
swiftlang/swift-syntax#2143 @swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce two minor improvements to the new diagnostics formatter:
remarkdiagnostic severity.