[CMake][SourceKit] Add RPATH to 'lib/swift/host' #68219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RPATH to 'lib/swift/host' was missing in Darwin platform.
rintaro
requested review from
ahoppen,
bnbarham and
hamishknight
as code owners
|
@swift-ci Please smoke test |
|
preset=asan |
bnbarham
approved these changes
Aug 30, 2023
|
ASAN failure is unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RPATH to 'lib/swift/host' was missing in Darwin platform.
Failure caused by #68082.
Before #68082 in macOS environment, sourcekitd-test had RPATH to
lib/swift/host, butsourcekitdInProcdidn't. It worked because.dylibinherits executable's RPATH. #68082 changed sosourcekit-testdoesn't have RPATH toswiftCoreand lib/swift/host because that executable itself didn't depend on it. But sincesourcekitdInProcdidn't have correct RPATH, it failed. Solution here is thatsourcekitdInProchave the correct RPATH.rdar://114700107