[ConstraintSystem] Handle incorrect key path member references earlier #68048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xedin
reviewed
Aug 22, 2023
| if (locator->isForKeyPathDynamicMemberLookup()) { | ||
| if (locator->isForKeyPathDynamicMemberLookup() || | ||
| locator->isForKeyPathComponent() || | ||
| locator->isKeyPathSubscriptComponent()) { |
There was a problem hiding this comment.
Maybe isKeyPathSubscriptComponent should be folded into isForKeyPathComponent?
xedin
approved these changes
Aug 22, 2023
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes move the check for invalid member reference in a keypath out of
simplifyKeyPathConstraintand intofixMemberRefso that it can be handled earlier in the typechecking process. Previously, it was skipped insimplifyKeyPathConstraintbecause the keypath components incorrectly appear to be fully resolved.