Skip to content

Delete backdeploy concurrency library #68029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

etcwilde
Copy link
Member

This library served its purpose and has overstayed its welcome. The library shipped in Xcode can't change again from the state it was in, so changes to the sources here will not affect that library, which is confusing. The library does not currently build due to changes in the runtime headers, so it does not give meaningful signal to anything anymore. If you need to test things in a backdeploy concurrency environment, use the copy from the toolchain in Xcode as that will give you a far clearer picture of what the code will actually be running with than the state of the sources here did.

rdar://105793056

This library served its purpose and has overstayed its welcome.
The library shipped in Xcode can't change again from the state it was
in, so changes to the sources here will not affect that library, which
is confusing. The library does not currently build due to changes in the
runtime headers, so it does not give meaningful signal to anything
anymore. If you need to test things in a backdeploy concurrency
environment, use the copy from the toolchain in Xcode as that will give
you a far clearer picture of what the code will actually be running with
than the state of the sources here did.
@etcwilde etcwilde requested review from DougGregor and edymtt August 20, 2023 18:11
@etcwilde
Copy link
Member Author

@swift-ci please test

@etcwilde
Copy link
Member Author

@swift-ci Please Build Toolchain macOS Platform

@ktoso
Copy link
Contributor

ktoso commented Aug 21, 2023

Yes please! It's an ongoing annoyance 👍

@etcwilde etcwilde merged commit 0f0e68f into swiftlang:main Aug 23, 2023
@tomerd
Copy link
Contributor

tomerd commented Aug 23, 2023

\o/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants