5.9: [IRGen] Cast fixed-size opaque globals. #67997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Resolves #67891 |
ktoso
approved these changes
Aug 18, 2023
In swiftlang#66560 , a bug in the lowering of `global_addr` was fixed. Part of that fix was to postpone mapping the type of the global into context until getting the address of the global and projecting the buffer for the out-of-line value; at that point, the type is mapped into context and the address is cast. It introduced an issue for fixed-size globals, however: the type of such globals was not mapped into context; the result was that the lowered value set for the corresponding SIL value would have the wrong type. Fix that by extracting the code which mapped the type into context and cast the address to the appropriate lowered type into a lambda and call that lambda both in both the fixed-size (newly) and non-fixed-size (as before) cases. rdar://114013709
nate-chandler
force-pushed
the
rdar114013709
branch
from
213bcd3 to
9372173
Compare
|
@swift-ci please test |
nate-chandler
changed the title
aschwaighofer
approved these changes
Aug 18, 2023
tbkka
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Add a missing cast when accessing fixed-size globals of opaque type.
Risk: Very low. The change applies code already in use in one code path (non-fixed size) to another (fixed-size).
Scope: Narrow. The change only affects fixed-size globals of opaque type.
Original PR: #68000
Reviewed By: Arnold Schwaighofer ( @aschwaighofer )
Testing: Added a test.
Resolves: rdar://114013709