[TaskGroup] reorder resumeWaiting->run and reenable async_taskgroup_discarding_dontLeak #67787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
changed the title
|
@swift-ci please test |
ktoso
added
the
concurrency
ktoso
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had resolved rdar://109998145 via the lock ordering fix in #67700
This is the same kind of test and cause radar to have disabled the test, so re-enable it.
We also have the "bad order" of
that we should correct in a separate commit here.
This might be the root cause of rdar://113331923, though I'm working on additional tests to verify
I'd like to use this PR to give this a few runs to verify.